Skip to content

Performance regressions from recursive type reference support #36566

Closed
@amcasey

Description

@amcasey

The extra work done in #33050 and follow-up PR #33678 is valuable, but maybe it doesn't need to be so expensive.

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

For #33050

  • 10-run avg on 4ee251b: 33,685ms
  • 10-run avg on 250d5a8: 34,223ms (2% slower)

For #33678

  • 10-run avg on 7f3c03d: 34,403ms
  • 10-run avg on 7ce793c: 35,488ms (3% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: PerformanceReports of unusually slow behaviorFix AvailableA PR has been opened for this issueNeeds InvestigationThis issue needs a team member to investigate its status.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions