Skip to content

Performance regressions from recursive type reference support #36566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amcasey opened this issue Feb 1, 2020 · 1 comment · Fixed by #36607
Closed

Performance regressions from recursive type reference support #36566

amcasey opened this issue Feb 1, 2020 · 1 comment · Fixed by #36607
Labels
Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue Needs Investigation This issue needs a team member to investigate its status.

Comments

@amcasey
Copy link
Member

amcasey commented Feb 1, 2020 •
edited
Loading

The extra work done in #33050 and follow-up PR #33678 is valuable, but maybe it doesn't need to be so expensive.

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

For #33050

  • 10-run avg on 4ee251b: 33,685ms
  • 10-run avg on 250d5a8: 34,223ms (2% slower)

For #33678

  • 10-run avg on 7f3c03d: 34,403ms
  • 10-run avg on 7ce793c: 35,488ms (3% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.
@amcasey amcasey added Needs Investigation This issue needs a team member to investigate its status. Domain: Performance Reports of unusually slow behavior labels Feb 1, 2020
@amcasey
Copy link
Member Author

amcasey commented Feb 1, 2020

FYI @ahejlsberg

@amcasey amcasey mentioned this issue Feb 3, 2020
Closed
@ahejlsberg ahejlsberg mentioned this issue Feb 4, 2020
Merged
@ahejlsberg ahejlsberg added the Fix Available A PR has been opened for this issue label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize deferred type references microsoft/TypeScript
2 participants
@ahejlsberg @amcasey