-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Debug Failure. False expression. in 'Object.createRange' during 'getEditsForFileRename' #37685
Comments
Revised stack format and updated hash. |
This issue reproduced in the following context:
|
This issue reproduced in the following context:
|
This issue reproduced in the following context:
|
This issue reproduced in the following context:
|
I am running into this issue when trying to rename a folder. (Renaming files seems to work.) Do you already have a reduced test case or do you need one? I am struggling to reduce it down but I can provide access to our project.
|
I added some logging to see what arguments we're passing in to if (updated !== undefined && updated !== importStringLiteral.text)
- changeTracker.replaceRangeWithText(sourceFile, createStringRange(importStringLiteral, sourceFile), updated);
+ {
+ console.log(JSON.stringify({ text: importStringLiteral.text, updated }), null, '\t')
+ changeTracker.replaceRangeWithText(sourceFile, createStringRange(importStringLiteral, sourceFile), updated);
+ } This logged:
This made me wonder whether the bug is something to do with having |
This issue reproduced in the following context:
|
@OliverJAsh do you still see this error in newer versions? |
All good now I think! Do you know what fixed it? Btw, it would be nice if compiler errors like the one above were more apparent. It took me awhile to figure out what was going on here because it was just failing silently. If there's a fatal error, I want to be notified so I can file an issue. I suggested this here but it was turned down 😒 microsoft/vscode#113559 |
This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript version prefix: 3.8.3
VSCode version: 1.43.2
Command requested: getEditsForFileRename
Hitting sessions: 2180
Five line hash: 26ad18b87d095b701e17d7b789e1cce5
Stack:
The text was updated successfully, but these errors were encountered: