Skip to content

Some diagnostic messages missing full stops/periods #37753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cherryblossom000 opened this issue Apr 2, 2020 · 0 comments · Fixed by #40165
Closed

Some diagnostic messages missing full stops/periods #37753

cherryblossom000 opened this issue Apr 2, 2020 · 0 comments · Fixed by #40165
Labels
Domain: Error Messages The issue relates to error messaging Experience Enhancement Noncontroversial enhancements Help Wanted You can do this Suggestion An idea for TypeScript
Milestone

Comments

@cherryblossom000
Copy link
Contributor

TypeScript Version: 3.8.3

Search Terms:
diagnostic messages full stop period
Code

declare const v: void
// An expression of type 'void' cannot be tested for truthiness
if (v) { }

// All type parameters are unused
class C<T, U> {
	static x: any
	static #x: any

	// Private identifiers cannot be used as parameters
	constructor(#x: any) {
		// Property 'x' is a static member of type 'C<T, U>'
		this.x
	}
}

Expected behavior:
Error messages should have a full stop/period at the end as per the guidelines. I fixed these as well as some other messages here.

Actual behavior:
No full stop.

Playground Link:
link

Related Issues:
none

@RyanCavanaugh RyanCavanaugh added Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript labels Apr 3, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Apr 3, 2020
@DanielRosenwasser DanielRosenwasser added Domain: Error Messages The issue relates to error messaging Help Wanted You can do this labels Aug 21, 2020
sandersn pushed a commit that referenced this issue Sep 8, 2020
* Add full stops in diagnostic messages (fixes #37753)

* Accept baselines

* Fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Error Messages The issue relates to error messaging Experience Enhancement Noncontroversial enhancements Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants