Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure find-all-refs works on unresolved locals #38836

Open
DanielRosenwasser opened this issue May 28, 2020 · 1 comment
Open

Ensure find-all-refs works on unresolved locals #38836

DanielRosenwasser opened this issue May 28, 2020 · 1 comment
Assignees
@ahejlsberg
Labels
Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Experimentation Needed Someone needs to try this out to see what happens In Discussion Not yet reached consensus Rescheduled This issue was previously scheduled to an earlier milestone Suggestion An idea for TypeScript
Milestone
TypeScript 5.7.0

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 28, 2020 •
edited
Loading

Spoke with @amcasey about this one.

Given the following

blah.yadda.yadda

blah will be an unresolved and should be an error, but we still want find-all-references on this symbol to work reasonably well. This is especially important in the mode described in #37713, where TypeScript won't have access to symbols in the global scope.

This can potentially be achieved by creating an "error scope" whose symbol table contents are progressively populated every time resolution fails.
@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript In Discussion Not yet reached consensus Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. labels May 28, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.0 milestone May 28, 2020
This was referenced Jun 12, 2020
Open
Open
Open
@sheetalkamat
Copy link
Member

Another option is to use results of navTo when symbol is not resolved instead of changing symbol tables?

@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label Aug 31, 2020
@sheetalkamat sheetalkamat mentioned this issue Apr 1, 2021
Closed
@DanielRosenwasser DanielRosenwasser added the Experimentation Needed Someone needs to try this out to see what happens label Sep 15, 2021
This was referenced Sep 15, 2021
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahejlsberg ahejlsberg

Labels
Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Experimentation Needed Someone needs to try this out to see what happens In Discussion Not yet reached consensus Rescheduled This issue was previously scheduled to an earlier milestone Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 5.7.0
Development

No branches or pull requests
5 participants
@DanielRosenwasser @andrewbranch @ahejlsberg @RyanCavanaugh @sheetalkamat