TS Server fatal error: Debug Failure. False expression.

[riginoommen]

Issue Type: Bug

❗️❗️❗️ Please fill in the sections below to help us diagnose the issue ❗️❗️❗️

TypeScript Version: 4.0.0-dev.20200727

TS Server Log
Server logging disabled. To help us fix crashes like this, please enable logging by setting:

"typescript.tsserver.log": "verbose"

After enabling this setting, future crash reports will include the server log.

TS Server Error Stack

Error: Debug Failure. False expression.
    at watchFailedLookupLocationsOfExternalModuleResolutions (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:107070:26)
    at resolveNamesWithLocalCache (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:106932:21)
    at Object.resolveModuleNames (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:106986:20)
    at InferredProject.Project.resolveModuleNames (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:147629:45)
    at actualResolveModuleNamesWorker (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:102605:133)
    at resolveModuleNamesWorker (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:102828:26)
    at resolveModuleNamesReusingOldState (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:102902:24)
    at processImportedModules (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:104401:35)
    at findSourceFile (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:104137:17)
    at /Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:103966:85
    at getSourceFileFromReferenceWorker (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:103933:34)
    at processSourceFile (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:103966:13)
    at processRootFile (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:103789:13)
    at /Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:102706:60
    at Object.forEach (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:188:30)
    at Object.createProgram (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:102706:16)
    at synchronizeHostData (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:143253:26)
    at Proxy.getProgram (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:143341:13)
    at InferredProject.Project.updateGraphWorker (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:148163:53)
    at InferredProject.Project.updateGraph (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:148096:42)
    at ProjectService.assignOrphanScriptInfoToInferredProject (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:150164:25)
    at ProjectService.assignProjectToOpenedScriptInfo (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:151693:26)
    at /Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:151954:97
    at Object.flatMap (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:513:25)
    at ProjectService.applyChangesInOpenFiles (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:151954:41)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:152947:46)
    at /Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:154805:88
    at IOSession.Session.executeWithRequestId (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:154796:28)
    at IOSession.Session.executeCommand (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:154805:33)
    at IOSession.Session.onMessage (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:154829:35)
    at Interface.<anonymous> (/Users/riginoommen/.vscode/extensions/ms-vscode.vscode-typescript-next-4.0.20200727/node_modules/typescript/lib/tsserver.js:157044:27)
    at Interface.emit (events.js:203:13)
    at Interface._onLine (readline.js:316:10)
    at Interface._normalWrite (readline.js:461:12)
    at Socket.ondata (readline.js:172:10)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

VS Code version: Code 1.47.2 (17299e413d5590b14ab0340ea477cdd86ff13daf, 2020-07-15T18:18:50.054Z)
OS version: Darwin x64 19.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	5, 6, 9
Memory (System)	16.00GB (0.64GB free)
Process Argv	-psn_0_843982
Screen Reader	no
VM	0%

Extensions (14)

Extension	Author (truncated)	Version
html-snippets	abu	0.2.1
ng-template	Ang	0.1000.4
vscode-apollo	apo	1.16.6
gitlens	eam	10.2.2
env-switcher	Eck	0.2.0
vscode-html-css	ecm	0.2.3
beautify	Hoo	1.5.0
Angular2	joh	9.1.2
dotenv	mik	1.0.1
vscode-docker	ms-	1.4.1
vscode-typescript-next	ms-	4.0.20200727
vscode-graphql	Pri	0.2.14
html-preview-vscode	tht	0.2.5
vscode-wakatime	Wak	4.0.0

[mjbvz]

Does this reproduce with all extensions disabled?

/needsMoreInfo

[mjbvz]

@sheetalkamat We've seen a number of reports of this specific crash in the last week: https://github.com/microsoft/vscode/issues?q=is%3Aissue+is%3Aopen+watchFailedLookupLocationsOfExternalModuleResolutions

None of the posters has included example code or steps to reproduce but it does seem to have started with TypeScript@next (potentially with 4.0.0-dev.20200717)

[mjbvz]

@RyanCavanaugh We continue to see reports of this against VS Code. Just want to make sure we investigate for the TS 4.0 stable release

[sheetalkamat]

i have looked at the code and nothing stood out. THis really seems like state gone bad so without repro code and/or server log its very hard to diagnose this.

[mjbvz]

Thanks @sheetalkamat. From what I can tell, this reports started around the 07/17 TypeScript 4.0 nightly. We see this error reported on both stable VS Code and VS Code insiders, so I don't think a recent VS Code change caused this

I've prompted users for more information on the linked issue with out any success so far

[sheetalkamat]

That gives a clue.. I think it could be 667ba74#diff-b023802c510974db50792b5c0e5a05fa which is reusing noResolveResolution

Will try to repro it, based on this

[sheetalkamat]

@amcasey @mjbvz We definitely need some kind of indication esp in telemetry so we can identify server mode easily? This turned out to be partial semantic mode resolution caching issue.