Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inlay hints #42073

Closed
5 tasks
Kingwl opened this issue Dec 22, 2020 · 4 comments · Fixed by #42089
Closed
5 tasks

Support inlay hints #42073

Kingwl opened this issue Dec 22, 2020 · 4 comments · Fixed by #42089
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Experimentation Needed Someone needs to try this out to see what happens Suggestion An idea for TypeScript

Comments

@Kingwl
Copy link
Contributor

Kingwl commented Dec 22, 2020 •
edited
Loading

Search Terms

editor, lsp, parameterHints

Suggestion

VSCode has supported decorators what could be implementation as label before some node.
We need to provide some text span to let vscode know .

Use Cases

Examples

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 22, 2020

I'd like to work on this both of ts and vscode If i may.

@Kingwl Kingwl changed the title Support Support parameterHints Dec 22, 2020
@Kingwl Kingwl closed this as completed Dec 22, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 22, 2020

microsoft/vscode#113276

@Kingwl Kingwl changed the title Support parameterHints Support inline parameterHints Dec 22, 2020
@Kingwl Kingwl reopened this Dec 22, 2020
@Kingwl Kingwl mentioned this issue Dec 22, 2020
Closed
@Kingwl Kingwl changed the title Support inline parameterHints Support inline signature arguments label Dec 22, 2020
@RyanCavanaugh RyanCavanaugh added Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript labels Dec 22, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 23, 2020 •
edited
Loading

I think it would also fix #41297

@Kingwl Kingwl mentioned this issue Dec 23, 2020
Merged
10 tasks
@Kingwl Kingwl changed the title Support inline signature arguments label Support inline hits Dec 24, 2020
@Kingwl Kingwl changed the title Support inline hits Support inline hints Dec 28, 2020
@DanielRosenwasser DanielRosenwasser added the Experimentation Needed Someone needs to try this out to see what happens label Jan 12, 2021
@Kingwl
Copy link
Contributor Author

Kingwl commented Jan 26, 2021

@xiaoxiangmoe No.

@Kingwl Kingwl changed the title Support inline hints Support inlay hints Jun 4, 2021
@shivjm shivjm mentioned this issue Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Experimentation Needed Someone needs to try this out to see what happens Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inlay hints support Kingwl/TypeScript
3 participants
@DanielRosenwasser @RyanCavanaugh @Kingwl