Skip to content

JavaScript - Typo in array fill method documentation #43597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pixieaka opened this issue Apr 7, 2021 · 2 comments · Fixed by #43627
Closed

JavaScript - Typo in array fill method documentation #43597

pixieaka opened this issue Apr 7, 2021 · 2 comments · Fixed by #43627
Labels
Experience Enhancement Noncontroversial enhancements Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
Backlog

Comments

@pixieaka
Copy link

pixieaka commented Apr 7, 2021

  • VS Code Version: 1.55.0
  • OS Version: Windows 10 20h2

Steps to Reproduce:

"Returns the this object" instead of "Returns this object".

Untitled

Does this issue occur when all extensions are disabled?: Yes
@pixieaka pixieaka changed the title JavaScript - Typo in array filter method documentation JavaScript - Typo in array fill method documentation Apr 7, 2021
@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 8, 2021
@mjbvz mjbvz removed their assignment Apr 8, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Apr 8, 2021 •
edited
Loading

Technically correct (fill does return the this object that it is invoked on) but the overall description of what this method does is very unclear. The whole description could use a clarification pass

@andrewbranch andrewbranch added Experience Enhancement Noncontroversial enhancements Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript labels Apr 9, 2021
@andrewbranch andrewbranch added this to the Backlog milestone Apr 9, 2021
@sangxxh sangxxh mentioned this issue Apr 10, 2021
Merged
@ShahzaibParacha
Copy link

Can I get in on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Experience Enhancement Noncontroversial enhancements Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Improve docstring for array fill methods
4 participants
@andrewbranch @mjbvz @pixieaka @ShahzaibParacha