-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial build mode build emits twice #43995
Comments
Copying this from #49156 (comment) I am having hard time reasoning about this change.
As part of this i am caching either transform or text (preferring text over transform) and declaration diagnostics so we can reuse it.
I havent been able to find repo where this benefits significantly. Numbers remain more or less same. |
From #42173 (comment)
In the course of investigating #42173, I noticed that a clean build of the largest project spent 50 seconds on emit. I picked out the slowest files and noticed that each occurred twice. It turns out that
updateShapeSignature
triggers a separate emit from the real one (fortunately, with no file writing), which accounts for 22 seconds of the emit time. Note that this was with TS 4.2 - 4.3 skips signature computation on a clean build.It seems like we could potentially realize a very significant perf win if we could combine the two emit passes. I believe @sheetalkamat has already been thinking about ways to do this.
The text was updated successfully, but these errors were encountered: