Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default branch is now named main #44323

Closed
RyanCavanaugh opened this issue May 28, 2021 · 7 comments
Closed

Default branch is now named main #44323

RyanCavanaugh opened this issue May 28, 2021 · 7 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@RyanCavanaugh
Copy link
Member

Heads up to contributors: We'll be renaming the default branch over the weekend to main. We believe we have the correct automation in place to update existing PRs, but you may need to update any personal scripts or muscle memory on your side to account for the change. Let us know if you encounter any technical issues with this.

Happy coding!

@RyanCavanaugh RyanCavanaugh added the Infrastructure Issue relates to TypeScript team infrastructure label May 28, 2021
@RyanCavanaugh RyanCavanaugh pinned this issue May 28, 2021
@orta
Copy link
Contributor

orta commented May 31, 2021

GitHub says this is going to close 3 open PRs, I assume they either have all their commits upstream'd but are still open, but will monitor the notifications and re-open (and re-target) them if it makes sense

Screen Shot 2021-05-31 at 10 40 43 AM

@orta
Copy link
Contributor

orta commented May 31, 2021

Used the GitHub API to find the 3 PRs which the migration auto-closed after the fact (I didn't get emails because they were my actions):

I checked via the API these are PRs which did not have the 'Allow maintainers to push to this branch' flag set on the PR which means GitHub reasoned that they couldn't be changed upstream. I'll leave a comment in them.

@orta
Copy link
Contributor

orta commented May 31, 2021

I've got #44347 validating our bot commands

@orta
Copy link
Contributor

orta commented May 31, 2021

Looks like build artifacts are not being passed between devops jobs as expected, they probably have master hardcoded as an arg somewhere - correctly it uploads nothing then can't be found by our scripts.

This was due to my PR being a bit facetious, working with a normal set of changes went fine 👍🏻

@orta
Copy link
Contributor

orta commented Jun 1, 2021

I'll keep this open for a week to give a central place for notes, but it all seems to be transferred over fine.

@orta
Copy link
Contributor

orta commented Jun 1, 2021

Not all CI systems are running on PRs:

Screen Shot 2021-06-01 at 3 49 37 PM

@RyanCavanaugh
Copy link
Member Author

Done and things seem to be running smoothly now

@RyanCavanaugh RyanCavanaugh changed the title Meta: Renaming default branch to main this weekend Default branch is now named main Jun 4, 2021
@DanielRosenwasser DanielRosenwasser unpinned this issue Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants