Sometimes when using JSX Tag completion, the trailing tag termination character disappears

[yamachu]

Does this issue occur when all extensions are disabled?: No

• VS Code Version: 1.62.0-insider (Universal) Commit: ff1e16e
• OS Version: macOS 10.15.7
• Extension: JavaScript and TypeScript Nightly v4.5.20211031

Steps to Reproduce:

1. Open React JSX file
2. Write a JSX tag and select the hovered completion content (with return key)

related issue
microsoft/vscode#82324

[mjbvz]

Possibly a similar root cause to microsoft/vscode#136377

Minimal example:

import * as React from 'react';

const a = (
    <span >

    </span>;
)

The replacement span returned is:

 "replacementSpan": {
                "start": {
                    "line": 4,
                    "offset": 11
                },
                "end": {
                    "line": 4,
                    "offset": 12
                }
            },

Which ends up replacing the closing >

[andrewbranch]

I think we probably don’t need a replacement span at all for JSX attribute completions. The identifier that the user started to type should already automatically be set as the optionalReplacementSpan on the top-level response. Otherwise, I don’t think there’s anything to replace.