-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Meeting Notes, 12/1/2021 #46983
Comments
Some clarification on the JSX issue at facebook/jsx#132 (comment). |
I want this so much, you have no idea.
Indeed - exactOptionalProperties is enabled in the aforementioned project, and I really want my |
btw I actually just learned today that |
Declare
const enum
s as Non-const
in Declaration Files#46626 (comment)
const enum
s are supposed to be inlined, butisolatedModules
issues an error because some compilers can't resolve across modules.preserveConstEnum
s - means you have a runtime representation, the compiler will inline the values, but downstream consumers technically can grab the values from runtime values.isolatedModules
orpreserveConstEnum
?preserve
modifier.preserveConstEnum
even a flag?isolatedModules
on a dependent project shouldn't have any bearing how a dependency should interpret thing.const enum
s again?const
existed.const
?preserved
keyword could ask "is this part of a project reference" and do the right thing?internal
- who is a declaration internal to? Module? Project? Package? Monorepo/solution? Something else?const enum
s.Partial
Adds| undefined
to Index Signatures inexactOptionalProperties
#46969
Partial
to a property, we add themissing
type to the property.undefined
implicitly.undefined
, but doesn't allow writes of it.noUncheckedIndexAccess
automatically adds theundefined
.?
on index signatures?noUncheckedIndexAccess
.exactOptionalProperties
mode.undefined
to the index signature.?
, we add a regularundefined
to the type, regardless ofexactOptionalProperties
.exactOptionalProperties
, we would probably use this in a few places.JSX Attribute Changes
Notes from @andrewbranch
facebook/jsx#132
Some people want to use template strings for everything, but the JSX spec doesn't currently allow it.
Also proposing reinterpreting the character values of a string from the ECMA262 spec to the WHATWG spec for HTML attributes, meaning:
would be interpreted differently.
There's a consistency problem:
In HTML, this is a tooltip with text
-
. In JSX, it's currently a tooltip with text‐
.Changing it would introduce a refactoring hazard if you change to:
React could do this during rendering instead of the JSX transformer doing it; that would still be a big breaking change.
The text was updated successfully, but these errors were encountered: