-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with AMD Plugin syntax #5729
Labels
Milestone
Comments
Is anyone able to comment on if this is expected behaviour and if there is any way to avoid it? |
this is not intentional it is a regression. @vladima can you take a look. |
@kitsonk can you give |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I was trying typescript@next (specifically v1.8.0-dev.20151120) and we extensively use AMD loader plugins, where we use
[module id]![resource id]
. In v1.6.2 and earlier we would simply declare an ambient declaration describing our module, for example, we have a module that reverts to the CommonJS loader and we would do something like this to load a CommonJS only module in our.d.ts
file:And then we would import it in module:
And everything worked fine. But it seems that at some point,
tsc
appears to only be matching up to the bang (!
) and either reporting the module not found, or matching returning whatever ambient declaration it matches and even with the ambient declaration above, I am gettingerror TS2307: Cannot find module 'intern/dojo/node'.
I tried to find the related change, but only thing I was aware of was #2709 and that doesn't look like that has been addressed yet.
Is there anyway to get
tsc
to revert to the previous behaviour?The text was updated successfully, but these errors were encountered: