Skip to content

DecodeErrorCallback in the Web Audio API has the wrong signature #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CShankland opened this issue Jan 19, 2016 · 3 comments
Closed

DecodeErrorCallback in the Web Audio API has the wrong signature #6534

CShankland opened this issue Jan 19, 2016 · 3 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@CShankland
Copy link

Relevant spec excerpt from section 2.1:

callback DecodeErrorCallback = void (DOMException error);

Definition from src/lib/dom.generated.d.ts:

interface DecodeErrorCallback {
    (): void;
}
@CShankland
Copy link
Author

A related issue is missing disconnect overloads in AudioNode (section 2.4):

    void      disconnect ();
    void      disconnect (unsigned long output);
    void      disconnect (AudioNode destination);
    void      disconnect (AudioNode destination, unsigned long output);
    void      disconnect (AudioNode destination, unsigned long output, unsigned long input);
    void      disconnect (AudioParam destination);
    void      disconnect (AudioParam destination, unsigned long output);

Existing dom.generated.d.ts definition:

disconnect(output?: number): void;

@mhegazy
Copy link
Contributor

mhegazy commented Jan 19, 2016

@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Jan 19, 2016
@mhegazy mhegazy added this to the Community milestone Jan 19, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jan 19, 2016

PRs are welcomed. You can find more informaiton about contributing lib.d.ts fixes at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

3 participants