Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa does not discover properties defined with Object.defineProperty #6651

Closed
egamma opened this issue Jan 27, 2016 · 2 comments · Fixed by #27208
Closed

Salsa does not discover properties defined with Object.defineProperty #6651

egamma opened this issue Jan 27, 2016 · 2 comments · Fixed by #27208

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 13:46

var obj1 = {};
Object.defineProperty(obj1, "x", { value: 42, writable: false });

obj1.

image

Copied from original issue: microsoft/vscode#2451

@billti
Copy link
Member

billti commented Jan 27, 2016

Per TypeScript semantics, we see obj1 as a {}, and don't support augmenting it (e.g. we also don't recognized adding via obj1.x = ...).

The type of obj1 can be explicitly set via a JsDoc comment. If you feel expando and defineProperty support is critical for Salsa, please reopen.

@alexdima
Copy link
Member

👍

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants