Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsDoc inline function signature does not honor optional params #6811

Closed
billti opened this issue Feb 2, 2016 · 0 comments
Closed

JsDoc inline function signature does not honor optional params #6811

billti opened this issue Feb 2, 2016 · 0 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@billti
Copy link
Member

billti commented Feb 2, 2016

The below two should be equivalent, however the optionality is lost of the second param on f6.

/** @type {function(string, boolean=): number} */
var f6;

/**
 * @param {string} p1
 * @param {boolean=} p2
 * @return {number}
 */
function f7(p1,p2){}
@billti billti added Bug A bug in TypeScript Salsa labels Feb 2, 2016
@mhegazy mhegazy added this to the TypeScript 1.8.2 milestone Feb 2, 2016
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Feb 3, 2016
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Feb 3, 2016
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Feb 5, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants