TypeError: Cannot read property 'type' of undefined at getJSDocTypeForVariableLikeDeclarationFromJSDocComment

[magnushiie]

With the current master, the compiler crashes when the @type JSDoc annotation of a variable is malformed, e.g. in the following (shortened) example from lodash:

/**
 * Checks if `value` is classified as an `Array` object.
 *
 * @type Function
 */
var isArray = Array.isArray;

This is in the statement return annotation.typeExpression.type;;

This compiles fine if Function above is replaced with {Function}.

It seems this is similar to #6709 and annotation.typeExpression needs checking too.

I could submit a PR, but I understand from CONTRIBUTING.md that the issue needs approval first?

[billti]

@RyanCavanaugh Seems like possibly the same root cause as #6984 .

[RyanCavanaugh]

Thanks for the report!

FWIW in the future if you find a crashing bug, we'll pretty much always accept PRs on those -- no need to wait for any action. But hopefully that doesn't happen again 😉