Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonky formatting inside TSX brackets with )} #8246

Closed
dbaeumer opened this issue Apr 22, 2016 · 2 comments
Closed

Wonky formatting inside TSX brackets with )} #8246

dbaeumer opened this issue Apr 22, 2016 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@dbaeumer
Copy link
Member

From @prencher on April 21, 2016 22:28

  • VSCode Version: 1.0
  • OS Version: Any

When formatting a TSX document, <span onClick={this.test()}> gets formatted as <span onClick={this.test() }>.

It appears isolated to ), for example <span onClick={this.test}> is unaffected, as is every other case I could think of to test.

I would assume this is supposed to not have spaces, or respect the non-empty bracket setting added in 1.0.

Copied from original issue: microsoft/vscode#5630

@dbaeumer
Copy link
Member Author

Agree. Moving to the TS team which provides the formatter.

@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2016

Duplicate of #6716

@mhegazy mhegazy closed this as completed May 23, 2016
@mhegazy mhegazy added the Duplicate An existing issue was already created label May 23, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants