Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX: Space is added before closing parenthesis #6716

Closed
djanosik opened this issue Jan 29, 2016 · 2 comments · Fixed by #9361
Closed

TSX: Space is added before closing parenthesis #6716

djanosik opened this issue Jan 29, 2016 · 2 comments · Fixed by #9361
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@djanosik
Copy link

When I format document a space is added before closing parenthesis.

image

It should not be added.

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jan 29, 2016
@mhegazy mhegazy added the Domain: Formatter The issue relates to the built-in formatter label Jan 29, 2016
@RyanCavanaugh RyanCavanaugh added the Help Wanted You can do this label Feb 7, 2016
@mhegazy mhegazy added this to the Community milestone Feb 24, 2016
@ibratoev
Copy link

ibratoev commented Jun 16, 2016

This is possibly related to another issue that I fight with in the moment in a TSX file:

  return (
    <span>({paramList})</span>
  );

is formatted to

  return (
    <span>({paramList}) </span>
  );

The space actually changes the behavior - something a formatter must not do.

@chicoxyzzy
Copy link
Contributor

wow bug in last comment is really serious and should be fixed

@RyanCavanaugh RyanCavanaugh modified the milestones: TypeScript 2.0, Community Jun 24, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jun 28, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants