Fix formatting on JsxElement/JsxExpression

[saschanaz]

Fixes #8817, fixes #6716

Input:

<div>,{integer}</div>;
<div>,   {integer}</div>;
<span>)</span>;
<span>)   </span>;
<Router routes={                3    } />;
<Router routes={                (3)    } />;

Current:

<div>, {integer}</div>;
<div>, {integer}</div>;
<span>) </span>;
<span>) </span>;
<Router routes={                3    } />;
<Router routes={                (3) } />;

Fix:

<div>,{integer}</div>;
<div>,   {integer}</div>;
<span>)</span>;
<span>)   </span>;
<Router routes={3} />;
<Router routes={(3)} />;

With new InsertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces option:

<div>,{ integer }</div>;
<div>,   { integer }</div>;
<span>)</span>;
<span>)   </span>;
<Router routes={ 3 } />;
<Router routes={ (3) } />;

[jwbay]

Would this change
<Router routes={ 3 } />;
to
<Router routes={3} />; ?

My team has adopted the first via a lint rule because the spacing makes it easier to read (subjective opinion, I know). If the TS formatter starts enforcing the second, well, there goes that 😅

[saschanaz]

@jwbay So we need an additional formatting option. Thanks for the information 👍

[saschanaz]

Now we have the option!

[RyanCavanaugh]

👍 greatly appreciated! 🏆

[mhegazy]

this needs to be optional, or it is a breaking change.

[saschanaz]

Sorry but I'm not sure what you mean by 'optional', do you want me to make it insert?: boolean form?

[mhegazy]

Thanks @saschanaz. one comment about the optionality of the new format option, and we are good to go.

[chicoxyzzy]

Does it also fix #6716 (comment)?

[zhengbli]

@chicoxyzzy Yes it does.

[zhengbli]

@saschanaz Can you update the PR today? As we are getting closer to snap 2.0, this needs to get in soon

[saschanaz]

@zhengbli I can if I get the answer for #9361 (comment). Not sure what 'optional' means here as any other fields on FormatCodeOptions are not optional.

[mhegazy]

Not sure what 'optional' means here as any other fields on FormatCodeOptions are not optional.

they were not optional originally, and that was a mistake. they should all have been optional from the get go.
Now adding a new one will break the build for any tool that uses formatting, even if they do not care to support this new option. so newer ones should be optional, and possibly we should go back and make all the options optional (no pun intended).

[saschanaz]

I think making it optional will make me forget adding corresponding fields on fourslash and editorServices for new default option value. Well, that is another story anyway ;)

[mhegazy]

thanks as always @saschanaz!