Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsx attribute formatting removes bracket spacing #11791

Closed
bookman25 opened this issue Sep 9, 2016 · 5 comments
Closed

tsx attribute formatting removes bracket spacing #11791

bookman25 opened this issue Sep 9, 2016 · 5 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@bookman25
Copy link

  • VSCode Version: 1.5.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. TypeScript Version: 2.*
  2. <input value={ this.state.value } />
  3. Format document

Expected behavior:
In 1.8.10 the spacing inside the brackets was unchanged on format operation (closing bracket } or format document).
<input value={ this.state.value } />

Actual behavior:
In 2.* the space inside the brackets is always removed when formatting.

<input value={this.state.value} />

Looks like it might be related to: microsoft/TypeScript#9361

@ramya-rao-a ramya-rao-a added the typescript Typescript support issues label Sep 9, 2016
@waderyan
Copy link

This issue was moved to microsoft/TypeScript#10872

@jwbay
Copy link

jwbay commented Sep 13, 2016

@waderyan per @saschanaz's comment in the TS repo, I checked and the relevant option is not present in VSCode: https://github.com/Microsoft/vscode/blob/master/extensions/typescript/src/features/formattingProvider.ts

Does it just need to be added there?

@waderyan
Copy link

@dbaeumer can you comment on the above? This might be something we want to add.

@dbaeumer
Copy link
Member

Yes, makes sense to add the option. Can you open an issue and set it to September.

@waderyan
Copy link

Issue created here

@waderyan waderyan added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 14, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants