Skip to content

JS config should not stop functioning if one of the files specified doesn't exist #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrieken opened this issue Apr 27, 2016 · 3 comments
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@jrieken
Copy link
Member

jrieken commented Apr 27, 2016

From @dbaeumer on March 21, 2016 20:47

  • VSCode Version: 0.10.12-alpha
  • OS Version: Windows 10

See screen shot. The jsconfig has a files section which should result in only having the two files in the project. Suggesting exclude rules makes not much sense.

capture

Copied from original issue: microsoft/vscode#4527

@jrieken
Copy link
Member Author

jrieken commented Apr 27, 2016

It seems TypeScript told me that a lot more files are part of that project... @dbaeumer In what repo does that happen?

@jrieken
Copy link
Member Author

jrieken commented Apr 27, 2016

From @dbaeumer on April 22, 2016 19:31

I can't remember, but I think it happend in out repository. It suggested to exclude /vs/ folder.

@jrieken
Copy link
Member Author

jrieken commented Apr 27, 2016

Ok, the problem is that the files section has an entry which doesn't exist and therefore the project won't exist.

@mhegazy mhegazy added Bug A bug in TypeScript API Relates to the public API for TypeScript labels Apr 27, 2016
@mhegazy mhegazy added this to the TypeScript 2.0 milestone Apr 27, 2016
@zhengbli zhengbli changed the title JS config assistent should not propose exclude rule if jsconfig has files section JS config should not stop functioning if one of the files specified doesn't exist Apr 29, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label May 17, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants