Tolerate non-existing files specified for tsserver #8504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengbli
changed the title
| for (const rootFilename of projectOptions.files) { | ||
| if (this.host.fileExists(rootFilename)) { | ||
| const info = this.openFile(rootFilename, /*openedByClient*/ clientFileName == rootFilename); | ||
| project.addRoot(info); | ||
| } | ||
| else { | ||
| const error = createCompilerDiagnostic(Diagnostics.File_0_not_found, rootFilename); | ||
| return { success: false, errors: [error] }; | ||
| errors.push(createCompilerDiagnostic(Diagnostics.File_0_not_found, rootFilename)); |
There was a problem hiding this comment.
consider using this pattern:
const errors: Diagnostic[];
...
(errors || errors = []).push(createCompilerDiagnostic(Diagnostics.File_0_not_found, rootFilename));There was a problem hiding this comment.
saves you the allocation in the normal case.
|
Can you add a fourslash test for this? |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8334. Now in the tsserver scenerio, if a file specified in tsconfig.json was not found, an config diagnostic event will be emitted, while the rest of the project will continue functioning.