Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Identifier between node.d.ts and lib.d.ts #8675

Closed
yuit opened this issue May 18, 2016 · 3 comments
Closed

Duplicate Identifier between node.d.ts and lib.d.ts #8675

yuit opened this issue May 18, 2016 · 3 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Milestone
TypeScript 2.0

Comments

@yuit
Copy link
Contributor

yuit commented May 18, 2016

TypeScript Version:

nightly with "node.d.ts" from typings

We recently add thisin to es5.d.ts
Expected behavior:
No error
Actual behavior:
Duplicate Identifier with the same property defined in "node.d.ts"
@yuit yuit added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels May 18, 2016
@mhegazy
Copy link
Contributor

mhegazy commented May 18, 2016

//CC @RyanCavanaugh who was mentioning this earlier this week.

@mhegazy mhegazy added this to the TypeScript 2.0 milestone May 18, 2016
@mhegazy
Copy link
Contributor

mhegazy commented May 18, 2016

The proposed fix is to relax the duplicate definition error for interface members if they have the same type.

@kitsonk
Copy link
Contributor

kitsonk commented May 19, 2016

👍 that will make lots of things easier!

RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue May 19, 2016
@RyanCavanaugh
Fixes microsoft#8675 by allowing duplicate identifiers across declara…
115317e 
…tions.

Duplicate identifiers *within the same block* are still disallowed.
@RyanCavanaugh RyanCavanaugh mentioned this issue May 19, 2016
Merged
@yortus yortus mentioned this issue May 22, 2016
Closed
@DanielRosenwasser DanielRosenwasser mentioned this issue May 22, 2016
Closed
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue May 24, 2016
@RyanCavanaugh
Allow duplicate identifiers as long as their declarations span multip…
675d176 
…le blocks

Fixes microsoft#8675
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Projects
None yet
Milestone
TypeScript 2.0
Development

No branches or pull requests
4 participants
@yuit @kitsonk @RyanCavanaugh @mhegazy