Skip to content

Gulpfile is missing some compiler settings #9608

Closed
@billti

Description

@billti

I was building and testing locally with Gulp without error, and when I pushed I got a noImplicitAny error on building the test harness (as the CI server still builds with Jake). Looking at the gulpfile, it seems to be missing a number of compiler settings compared to the jakefile, e.g. --noImplicitAny --noEmitOnError --types --pretty --preserveConstEnums --inlineSourceMap --inlineSources. It appears to only set the outFile (https://github.com/Microsoft/TypeScript/blob/master/Gulpfile.ts#L579 ).

From a quick scan, it looks like it might be doing the same when building tsserver.js also (at line 496), so perhaps the Gulpfile needs an audit for safety before it becomes the default build.

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScript

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions