Tolerate errors in config file #10418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const error = createCompilerDiagnostic(Diagnostics.The_config_file_0_found_doesn_t_contain_any_source_files, configFilename); | ||
| return { succeeded: false, errors: [error] }; | ||
| return { succeeded: false, errors: concatenate(parsedCommandLine.errors, [error]) }; |
There was a problem hiding this comment.
do you still need the succeeded property? it seems that now we are handling the two branches identically.
There was a problem hiding this comment.
They are still different though. succeeded is true means we can proceed with building projects even if some minor errors exist, but succeeded is false means the errors are too serious that we are not going to build anything. Either invalid json and empty project will result in the later case.
There was a problem hiding this comment.
even if it is invalid, why should not we build one? we found tsconfig.json, and we know the open file. so we can create a project with just that..
zhengbli
force-pushed
the
tolerateConfigError
branch
from
110b5df to
a8ab52f
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9577
Now uses the TypeScript parser to parse tsconfig.json to be more tolerating