Add getOrUpdate helper
#10436
Closed
Add getOrUpdate helper
#10436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
ghost
assigned 
| @@ -326,7 +326,7 @@ namespace ts { | |||
| // Otherwise, we'll be merging into a compatible existing symbol (for example when | |||
| // you have multiple 'vars' with the same name in the same container). In this case | |||
| // just add this node into the declarations list of the symbol. | |||
| symbol = symbolTable[name] || (symbolTable[name] = createSymbol(SymbolFlags.None, name)); | |||
| symbol = getOrUpdate(symbolTable, name, () => createSymbol(SymbolFlags.None, name)); | |||
There was a problem hiding this comment.
Oddly enough, I had removed this exact function to avoid the closure on this line.
|
what is the reason for this change? |
|
Just a pattern I noticed while going through uses of maps. |
|
This is now part of #11354 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.