Remove service's jsdoc parser and enhance parser's jsdoc parser #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modify scanner's definition of leading vs trailing comments, with associated changes to emitter and emit baselines (the last is in a separate commit).
|
@RyanCavanaugh you may be interested in this change if you like parsers (because I improved one), or if you don't (because I got rid of another one). |
Plus cleanup some lint
Also update a couple of missed spots in the previous undo commits
|
@yuit you said you wanted to read parser code for some reason, so here it is. :] 🎁 |
Also use a `pushComments` function, which fixes a spacing bug.
RyanCavanaugh
approved these changes
Sep 14, 2016
| let advanceToken = true; | ||
| let state = JSDocState.SawAsterisk; | ||
| let margin: number | undefined = undefined; | ||
| let indent = start - Math.max(content.lastIndexOf("\n", start), 0) + 4; |
There was a problem hiding this comment.
Oh. That part is embarassing. 4 === '/** '.length, basically. I should add a comment like the one on line 6179
This was referenced Dec 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the services code parsed the comment part of jsdoc and the parser parsed the type information of jsdoc. This change makes the parser parse both comments and type information from jsdoc. The parser now parses jsdoc for both TypeScript and JavaScript.
It doesn't add much coverage of other jsdoc tags, and it doesn't fix all the annoying architectural problems, but it closes almost all of the jsdoc bugs people have found so far:
Fixes #7136
Fixes #6810
Fixes #6992
Fixes #7243
Fixes #9809
Fixes #9882
Fixes #9971
Fixes #10535