Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use returned values from super calls as 'this' #10762

Merged
merged 44 commits into from
Sep 30, 2016
Merged

Use returned values from super calls as 'this' #10762

merged 44 commits into from
Sep 30, 2016

Commits on Sep 2, 2016

  1. Emit '_this' declaration for derived classes; initialize it when call… 

    …ing 'super(...)'.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    9dbab97 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    99f1df4 View commit details
    Browse the repository at this point in the history

  3. Transform other instances of 'this' to '_this' when in the constructo… 

    …r of a derived class.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    d778e78 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines for all tests apart from one with source map changes.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    c21cc24 View commit details
    Browse the repository at this point in the history

  5. Accepted baselines for sourcemap test.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    9c6e148 View commit details
    Browse the repository at this point in the history

  6. Always tack on a return statement for '_this' in derived classes.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    cd5e76b View commit details
    Browse the repository at this point in the history

  7. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    30ec599 View commit details
    Browse the repository at this point in the history

  8. Ensure prologue directives occur first.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    bab6d6f View commit details
    Browse the repository at this point in the history

  9. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    ce953ce View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2016

  1. Consolidate '_this' declaration and assignments for first statements … 

    …in constructors.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    d6e548b View commit details
    Browse the repository at this point in the history

  2. Fixed issue where last function context & parent node wasn't being pr… 

    …eserved.

This came up when a `super()` call was nested in another constructor body.
Current logic in the transform says that if the last containing non-arrow
function body is non-static, and the current parent isn't a call expression,
the call target of a `super` call will become `_super.prototype` instead
of `super`.

If the state is not saved, the containing arrow function and parent
are not saved, and the information for this check won't be accurate.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    11bc6c4 View commit details
    Browse the repository at this point in the history

  3. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    d8846dd View commit details
    Browse the repository at this point in the history

  4. Always perform this captures after default & rest parameters.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    86088d0 View commit details
    Browse the repository at this point in the history

  5. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    dd27139 View commit details
    Browse the repository at this point in the history

  6. Added a test for branched returns at the end of a constructor.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    f3dcaae View commit details
    Browse the repository at this point in the history

  7. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    1be4cee View commit details
    Browse the repository at this point in the history

  8. Don't emit a return statement at the end in most useful cases.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    c87a773 View commit details
    Browse the repository at this point in the history

  9. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    d144665 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2016

  1. Added test for '_this'.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    b476815 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    230737f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2016

  1. Mark constructors as this-capturing if they are defined in a derived … 

    …class.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    b11db57 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into useReturnedThisFromSuperCalls

    @DanielRosenwasser
    DanielRosenwasser committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    25f9555 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    3a5fb0c View commit details
    Browse the repository at this point in the history

  2. Added missing semicolons.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    f11c646 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Merge remote-tracking branch 'origin/master' into useReturnedThisFrom… 

    …SuperCalls
    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    a63a0d8 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    138e18c View commit details
    Browse the repository at this point in the history

  3. Added test and comment.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    da29813 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    60bcd7e View commit details
    Browse the repository at this point in the history

  5. Always mark derived constructors as 'this'-capturing.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    5b3a93d View commit details
    Browse the repository at this point in the history

  6. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    bc4cf6d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2016

  1. Immediately return the result of super calls when they are the first … 

    …& last statement in a constructor.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    dc58fb5 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    cd787cc View commit details
    Browse the repository at this point in the history

  3. Initialize instead of letting the value be potentially undefined.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    6580262 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into useReturnedThisFrom… 

    …SuperCalls
    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    3e8fb37 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2016

  1. Merge remote-tracking branch 'origin/master' into useReturnedThisFrom… 

    …SuperCalls
    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    5fadfd4 View commit details
    Browse the repository at this point in the history

  2. Remove usage of 'useCapturedThis'.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    4a5830d View commit details
    Browse the repository at this point in the history

  3. Collapse 'super()' capture/returns into a single return statement for… 

    … generated 'super()' calls.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    c668644 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    1fbdb86 View commit details
    Browse the repository at this point in the history

  5. Restore arrow function.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    e0c35f2 View commit details
    Browse the repository at this point in the history

  6. Reuse the 'captureThisForNode' function.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    f8fbc22 View commit details
    Browse the repository at this point in the history

  7. Removed pointlessish overloads.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    fb4b503 View commit details
    Browse the repository at this point in the history

  8. Moved code around, fixed indent, reworded comment.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    b5a1031 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Consolidated 'super()' transformation logic into one function.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    c29ec6f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2016

  1. Merge remote-tracking branch 'origin/master' into useReturnedThisFrom… 

    …SuperCalls
    @DanielRosenwasser
    DanielRosenwasser committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    02b9917 View commit details
    Browse the repository at this point in the history