fix flow in finally blocks #11675
Merged
fix flow in finally blocks #11675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Oct 17, 2016
| // console.log(2); // this line should be unreachable even if flow falls out of finally block | ||
| if (!(currentFlow.flags & FlowFlags.Unreachable)) { | ||
| if ((flowAfterTry.flags & FlowFlags.Unreachable) && (flowAfterCatch.flags & FlowFlags.Unreachable)) { | ||
| currentFlow = flowAfterTry == reportedUnreachableFlow || flowAfterCatch === reportedUnreachableFlow |
| } | ||
| if (node.finallyBlock) { | ||
| currentFlow = preTryFlow; | ||
| // in finally flow is combined from pre-try/flow from try/flow from catch | ||
| // pre-flow is necessary to make sure that finally is reachable even if finaly flows in both try and finally blocks are unreachable |
mhegazy
approved these changes
Oct 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11665.
Make initial flow in finally block a combination from start flow in
try, final flow intryand final flow incatchblocks