Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: <script type="ts/module"> #12170

Closed
wants to merge 1 commit into from

Conversation

gertcuykens
Copy link

@gertcuykens gertcuykens commented Nov 11, 2016

#11739

I am going trough the source code to try to see if I can do it, but I got stuck fairly quickly, I got .ts.html extension in but where do i go tell tsc to first look for the <script> tag when it parses a .ts.html ?

This question doesn't fit for stackoverflow so I was hoping we could collaborate in a pull request

@msftclas
Copy link

Hi @gertcuykens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@gertcuykens gertcuykens force-pushed the master branch 3 times, most recently from c47563c to cecf84f Compare November 11, 2016 20:13
@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2017

As noted in #11739 (comment), I think the correct approach here is to use a language service plugin. adding HTML parsing support to the TS compiler is not the correct path.

@mhegazy mhegazy closed this May 23, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants