Skip to content

Codegen: Do not subtract 0 in arguments to rest array loop #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

subzey
Copy link
Contributor

@subzey subzey commented Nov 14, 2016

Fixes #12188

@msftclas
Copy link

Hi @subzey, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. @rbuckton you have final say on emit. What do you think?

@subzey subzey force-pushed the feature/rest-loop-index branch from 5a28f80 to 3e52f3d Compare November 17, 2016 19:07
@subzey
Copy link
Contributor Author

subzey commented Nov 17, 2016

New commit is pushed to this PR to avoid merge conflict.

@mhegazy mhegazy merged commit 9fec775 into microsoft:master Nov 18, 2016
@subzey subzey deleted the feature/rest-loop-index branch November 18, 2016 08:53
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants