switch to execSync to ensure that no install requests are interleaved #12259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Nov 15, 2016
vladima
added a commit
that referenced
this pull request
Nov 15, 2016
vladima
added a commit
that referenced
this pull request
Nov 15, 2016
* treat failures to resolve module name as missing packages (#12237) * added extra check to prevent multiple installation of the same typing, added version field to telemetry event (#12258) * added extra check to prevent multiple installation of the same typing, added version field to telemetry event * use ts.version * switch to execSync to ensure that no install orders are interleaved (#12259) * Make sure version is public * Update file with version string for nightly release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// CC @mhegazy, @billti
Currently typings installer processes requests one by one and runs installation asyncronously. Cache of installed typings is updated after
npm installis done. This means that there might be an interesting situation when installer receives two requests in a row to install typings for different projects. After first request installer will discover that typings are not yet there and will kick offnpm install. However if second request will come beforenpm installis completed then installer will think that typings are not installed and will run second instance ofnpm installprocess. Simplest way to deal with this issue is to switchnpm installto be synchronous so all requests are processed serially.