Improve diagnostic messages for imported helpers #12305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested changes
Nov 27, 2016
| @@ -1023,6 +1023,10 @@ | |||
| "category": "Error", | |||
| "code": 2342 | |||
| }, | |||
| "This syntax requires an imported helper named '{1}', but module '{0}' has no exported member '{1}'.": { | |||
There was a problem hiding this comment.
This follows the same pattern as 2305: "Module '{0}' has no exported member '{1}'."
DanielRosenwasser
approved these changes
Nov 30, 2016
|
Looks good otherwise, just need merge conflicts addressed |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the diagnostic messages for imported helpers, changes how imported helpers are checked, and removes
NodeFlagsenum members related to emit helpers that are no longer needed.// cc: @vladima, @mhegazy