Skip to content

Reuse code from convertJsonOptionOfCustomType #12708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Dec 7, 2016
Merged

Reuse code from convertJsonOptionOfCustomType #12708

1 commit merged into from
Dec 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2016

These functions had identical content, except that parseCustomTypeOption trims its input and ensures it's defined.

@ghost ghost assigned yuit Dec 7, 2016
@ghost ghost merged commit 7b1fc21 into master Dec 7, 2016
@ghost ghost deleted the convert_json_option branch December 7, 2016 16:58
@mhegazy mhegazy mentioned this pull request Dec 12, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandersn @yuit @msftclas