Skip to content

Improve async stepping #12817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2016
Merged

Improve async stepping #12817

merged 2 commits into from
Dec 22, 2016

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Dec 10, 2016 •
edited by DanielRosenwasser
Loading

Improves debug stepping for async functions in VS Code with "smartStep" enabled in your launch configuration. This specifically addresses two issues:

  • Setting a breakpoint on a line with a variable statement that contains an await in an initializer.
  • Stepping into an if statement that contains an await.

Related: #12390

@rbuckton rbuckton requested review from billti and mhegazy December 19, 2016 19:14
@billti
Copy link
Member

billti commented Dec 19, 2016

Looks good to me, but I'm not super familiar with the code, so might want to wait for @mhegazy

@rbuckton rbuckton merged commit 4e4892a into master Dec 22, 2016
@rbuckton rbuckton deleted the improveAsyncStepping branch December 22, 2016 19:45
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

@billti billti Awaiting requested review from billti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @billti @mhegazy @msftclas