Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include selected local subdirs in baseline-accept #13587

Closed
wants to merge 1 commit into from
Closed

Include selected local subdirs in baseline-accept #13587

wants to merge 1 commit into from

Conversation

pcj
Copy link

@pcj pcj commented Jan 20, 2017

Working on #13217, was not able to get a transpile to test to accept, solved in response to @RyanCavanaugh #13217 (comment).

This PR is quick and dirty. It may be sufficient as-is, or may elicit a discussion re: a more elegant way to do this... Should it just be a completely recursive solution (search all subdirs), or are only selected folders intended to be named in $ jake baseline-accept?

@msftclas
Copy link

Hi @pcj, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Jan 20, 2017

Please update the gulpfile as well - they need to do the same thing. (And please don't ask why we have two build files to do the same thing 😢 )

@mhegazy
Copy link
Contributor

mhegazy commented Jan 21, 2017

should we just drop the gulp file?

@RyanCavanaugh
Copy link
Member

I would vote for getting rid of the jakefile, or at the very least turning all the jake targets into aliases for the gulp targets. Having two implementations is getting old.

@pcj
Copy link
Author

pcj commented Jan 21, 2017

Kind of funny you each proposed getting rid of the opposite file 😄. So which one are people using? I went with jake as this was part of the instructions in the CONTRIBUTING.md, but I have no preference (It was the first time I had encountered this particular build tool).

If you have a consensus, I'd be happy to delete that file and update the documentation.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 21, 2017

I still use jake. just muscle memory though. gulp seems fine, my only concern is that it is slower.

@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2017

should be covered by the change in abae1bd

@mhegazy mhegazy closed this May 23, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants