ES6 and above targets emit Object.assign for object spread #13757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also omits the __assign helper
|
@rbuckton mind taking a look? |
mhegazy
suggested changes
Jan 30, 2017
| @@ -402,6 +402,11 @@ namespace ts { | |||
| }; | |||
|
|
|||
| export function createAssignHelper(context: TransformationContext, attributesSegments: Expression[]) { | |||
| if (context.getCompilerOptions().target >= ScriptTarget.ES2015) { | |||
There was a problem hiding this comment.
we are still checking for it under --importHelpers in the checker i believe. you need to change that to ES2015 as well. and also add a test for it.
There was a problem hiding this comment.
Thanks for catching that. Fixed.
Instead, Object.assign is emitted.
mhegazy
approved these changes
Jan 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they would always emit
__assignand its helper definition, even thoughObject.assignis always available in ES2015 and above.Fixes #12901