Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wip] Fix 11566 : allow null return in SFC #14045

Closed
wants to merge 2 commits into from

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Feb 13, 2017

Fix #11566.... This PR is need to be open against master when this PR #13640 is merged.

When check return type of SFC, instead of checking against just JSX.Element, we check the return type against JSX.Element and null.

The change here will be the one ported to DefinitelyTyped

@yuit yuit requested a review from RyanCavanaugh February 13, 2017 18:49
@yuit yuit closed this Feb 15, 2017
@yuit yuit deleted the master-fix11566 branch February 15, 2017 18:29
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants