Do not report semantic diagnostics for infered and external projects with only .js files #14716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with only .js files
vladima
approved these changes
Mar 18, 2017
billti
reviewed
Mar 18, 2017
| return true; | ||
| } | ||
| return false; | ||
| return (project.projectKind === ProjectKind.Inferred || project.projectKind === ProjectKind.External) && project.isJsOnlyProject(); |
There was a problem hiding this comment.
So if they're using a "configured" project (e.g. a lot of our solutions for issues such as "too much JavaScript" involve adding a tsconfig with "allowJs": true and settings some exclude dirs), will they get semantic diagnostics again? If its a configured project with "allowJs" set and it isJsOnlyProject, then it should also suppress semantic diagnostics.
There was a problem hiding this comment.
correct. if you have configured project the check is false, and the normal checking for semantic errors proceed. this is only if you have external or inferred project, with only .js files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14565
//CC: @vladima, @zhengbli and @RyanCavanaugh