-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Add missing methods for FormData type #14859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NColey, It will cover your contributions to all Microsoft-managed open source projects. |
@NColey, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Thanks for your PR. these files are not manually edited, they are auto-generatd from a script in . You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TSJS-lib-generator. Changes should be done in https://github.com/Microsoft/TSJS-lib-generator instead. Please find more information at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes. |
@NColey, |
Your changes to src/lib/DOM.iterable.d.ts we should take, please revert the other changes and send them to TSJS-lib-generator instead. |
src/lib/dom.iterable.d.ts
Outdated
/** | ||
* Returns an array of key, value pairs for every entry in the list | ||
*/ | ||
entries(): IterableIterator<[string, any]>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from spec, the values are string | File
; that applies to value
, entries
and [Symbol.iterator]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the PR with the appropriate types, thanks!
thanks! |
Fixes #14813.