Disallow destructured parameter properties #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
force-pushed
the
unDestructuringParameterProperties
branch
from
e2be011 to
e19ebc6
Compare
| @@ -10169,6 +10172,9 @@ module ts { | |||
| else if (node.kind === SyntaxKind.InterfaceDeclaration && flags & NodeFlags.Ambient) { | |||
| return grammarErrorOnNode(lastDeclare, Diagnostics.A_declare_modifier_cannot_be_used_with_an_interface_declaration, "declare"); | |||
| } | |||
| else if (node.kind === SyntaxKind.Parameter && (flags & NodeFlags.AccessibilityModifier) && isBindingPattern((<ParameterDeclaration>node).name)) { | |||
There was a problem hiding this comment.
How can node.kind be Parameter if node is a SignatureDeclaration?
There was a problem hiding this comment.
To clarify, it's not, GitHub diffs break after 10K lines.
|
👍 |
1 similar comment
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jan 15, 2015
…rties Disallow destructured parameter properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1540 and #1541.