Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a branded type for identifier-escaped strings #16915

Merged
merged 26 commits into from
Jul 6, 2017
Merged

Created a branded type for identifier-escaped strings #16915

merged 26 commits into from
Jul 6, 2017

Commits on Jul 3, 2017

  1. Created a branded type for escaped strings 

    Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.
    @weswigham
    weswigham committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    042a78d View commit details
    Browse the repository at this point in the history

  2. Correctly double underscores WRT mapped types

    @weswigham
    weswigham committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    ce4018c View commit details
    Browse the repository at this point in the history

  3. Add fourslash tests for other fixed issues

    @weswigham
    weswigham committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    342ec75 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into escaped-string-type

    @weswigham
    weswigham committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    770010e View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. use function call over cast

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    1f55366 View commit details
    Browse the repository at this point in the history

  2. Update forEachEntry type accuracy

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    4411889 View commit details
    Browse the repository at this point in the history

  3. Just use escaped names for ActiveLabel

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    47f7fbd View commit details
    Browse the repository at this point in the history

  4. Remove casts from getPropertyNameForPropertyNameNode

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    7f22f39 View commit details
    Browse the repository at this point in the history

  5. This pattern has occurred a few times, could use a helper function.

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    f88f21a View commit details
    Browse the repository at this point in the history

  6. Remove duplicated helper

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    af30041 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded check, use helper

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    5d9ea3a View commit details
    Browse the repository at this point in the history

  8. Identifiers list is no longer escaped strings

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    352c13d View commit details
    Browse the repository at this point in the history

  9. Extract repeated string-getting code into helper

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    b371e7a View commit details
    Browse the repository at this point in the history

  10. Rename type and associated functions

    @weswigham
    weswigham committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    ba0071e View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Make getName() return UnderscoreEscapedString, add getUnescapedName()

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    e0c7dcc View commit details
    Browse the repository at this point in the history

  2. Add list of internal symbol names to escaped string type to cut back … 

    …on casting
    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    50a8c04 View commit details
    Browse the repository at this point in the history

  3. Remove outdated comments

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    3398d41 View commit details
    Browse the repository at this point in the history

  4. Reassign interned values to nodes, just in case

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    a4bd2ab View commit details
    Browse the repository at this point in the history

  5. Swap to string enum

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    0967927 View commit details
    Browse the repository at this point in the history

  6. Add deprecated aliases to escapeIdentifier and unescapeIdentifier

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    e99b679 View commit details
    Browse the repository at this point in the history

  7. Add temp var

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    3383d8a View commit details
    Browse the repository at this point in the history

  8. Remove unsafe casts

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    5eca8a3 View commit details
    Browse the repository at this point in the history

  9. Rename escaped string type as per @sandersn's suggestion, fix string … 

    …enum usages
    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    9424f14 View commit details
    Browse the repository at this point in the history

  10. Reorganize double underscore tests

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    23032d4 View commit details
    Browse the repository at this point in the history

  11. Remove jfreeman from TODO

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    008532d View commit details
    Browse the repository at this point in the history

  12. Remove unneeded parenthesis

    @weswigham
    weswigham committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    5e6b69a View commit details
    Browse the repository at this point in the history