Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es5.d.ts #17261

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Update es5.d.ts #17261

merged 1 commit into from
Aug 9, 2017

Conversation

unional
Copy link
Contributor

@unional unional commented Jul 18, 2017

Objects.keys() does not take null or undefined

> Object.keys(undefined)
TypeError: Cannot convert undefined or null to object
> Object.keys(null)
TypeError: Cannot convert undefined or null to object

[x] You've signed the CLA
[x] There are new or updated unit tests validating the change

@houfio
Copy link

houfio commented Jul 18, 2017

What about object?

@unional
Copy link
Contributor Author

unional commented Jul 18, 2017

What about object?

object doesn't work with true and false

@ikatyang
Copy link
Contributor

Related issue #17273

@rbuckton rbuckton requested a review from sandersn August 9, 2017 20:48
@rbuckton
Copy link
Member

rbuckton commented Aug 9, 2017

I think this looks like a good change, but would like to get some additional input. @sandersn, do you see any issues with this change?

@sandersn
Copy link
Member

sandersn commented Aug 9, 2017

Looks good to me.

@sandersn sandersn merged commit 445cc8d into microsoft:master Aug 9, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants