Mapped type and string index signature relations #17633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Aug 7, 2017
| y = x; // Error | ||
| } | ||
|
|
||
| function f2<T, K extends string>(x: { [key: string]: T }, y: Record<string, T>) { |
There was a problem hiding this comment.
what's the point of this test? K isn't used.
There was a problem hiding this comment.
I guess it's to assert that the key type of Record doesn't matter, only the mapped type's template type. Seems self-evident to me, but maybe it's worth a test.
There was a problem hiding this comment.
To me it appears to be unused and unnecessary for the test. @ahejlsberg, is the type parameter K needed for this test?
There was a problem hiding this comment.
Yeah, no need to have that type parameter. Will fix.
rbuckton
requested changes
Aug 7, 2017
| y = x; // Error | ||
| } | ||
|
|
||
| function f2<T, K extends string>(x: { [key: string]: T }, y: Record<string, T>) { |
There was a problem hiding this comment.
To me it appears to be unused and unnecessary for the test. @ahejlsberg, is the type parameter K needed for this test?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR a mapped type
{ [P in K]: T }, whereKis generic, is related to a string index signature{ [key: string]: U }ifTis related toU. For example:Fixes #14548. Also fixes an unintended effect of #17382 that would allow any generic mapped type to be assignable to a string index signature (because generic mapped types have no manifest properties they were being mistaken for empty object types).