Fix stack overflow related to contextual signature instantiations #17634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RyanCavanaugh @rbuckton @sandersn We should get this into 2.5 RC. |
sandersn
approved these changes
Aug 7, 2017
| @@ -10670,7 +10671,7 @@ namespace ts { | |||
| const constraint = getConstraintOfTypeParameter(context.signature.typeParameters[index]); | |||
| if (constraint) { | |||
| const instantiatedConstraint = instantiateType(constraint, context); | |||
| if (!isTypeAssignableTo(inferredType, getTypeWithThisArgument(instantiatedConstraint, inferredType))) { | |||
| if (!context.compareTypes(inferredType, getTypeWithThisArgument(instantiatedConstraint, inferredType))) { | |||
There was a problem hiding this comment.
is there anywhere else this could be used in place of a hard-coded call? I looked around and didn't see any, but I wonder if you noticed any while making this fix.
rbuckton
approved these changes
Aug 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we properly propagate a type comparison function through to the type inference process used in contextual signature instantiation, such that type comparisons done during constraint checking become aware of other type comparisons already in progress.
Fixes #17148.