Allow quoted names in completions #18162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested changes
Aug 30, 2017
src/services/completions.ts
Outdated
| } | ||
|
|
||
| return name; | ||
| } | ||
|
|
||
| function isNumericLiteralText(name: string): boolean { | ||
| return /^-?\d+(\.\d+)?(e\d+)?$/.test(name); |
There was a problem hiding this comment.
There are contexts like property names:
const foob = {
-0() {
return 1;
}
};where a leading minus would never be allowed (only an identifier, string literal, or number) - I don't think this should include the check for -??
There was a problem hiding this comment.
Also, this helper probably should be somewhere central, since it will need to be updated once we support the numeric seperator proposal.
There was a problem hiding this comment.
We can just use a string literal in this case then, which makes this function unnecessary. 👍
…nd use string literals for number keys
mhegazy
reviewed
Sep 6, 2017
src/services/completions.ts
Outdated
| // If the user entered name for the symbol was quoted, removing the quotes is not enough, as the name could be an | ||
| // invalid identifier name. We need to check if whatever was inside the quotes is actually a valid identifier name. | ||
| // e.g "b a" is valid quoted name but when we strip off the quotes, it is invalid. | ||
| // We, thus, need to check if whatever was inside the quotes is actually a valid identifier name. | ||
| if (performCharacterChecks && !isIdentifierText(name, target)) { | ||
| return undefined; | ||
| return allowStringLiteral ? JSON.stringify(name) : undefined; |
There was a problem hiding this comment.
that would be another place where a user-defined quote setting will need to be honored.
mhegazy
approved these changes
Sep 6, 2017
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17040
This was a pretty simple change as I just had to change the code that had previously been returning
undefinedon any quoted name.There may be objections to this as there were to #16864, so CC @rbuckton @weswigham