Error on excessively large control flow graphs #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Sep 5, 2017
mhegazy
reviewed
Sep 6, 2017
src/compiler/checker.ts
Outdated
| // excessive amount of time and possibly overflowing the call stack, we report an error and disable | ||
| // further control flow analysis in the containing function or module body. | ||
| flowAnalysisDisabled = true; | ||
| error(reference, Diagnostics.The_body_of_the_containing_function_or_module_is_too_large_for_control_flow_analysis); |
There was a problem hiding this comment.
we talked about putting this on the containing function if one exists. this way ppl have a consistent place to see the error, instead of it jumping around as they add/remove lines.
mhegazy
approved these changes
Sep 6, 2017
mhegazy
approved these changes
Sep 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our handling of excessively large control flow graphs: If control flow analysis leads to a stack depth of 2500 recursive calls, we now issue an error and disable control flow analysis for the remainder of the containing function or module body. Previously we'd simply overflow the call stack.
The 2500 recursive call limit was experimentally determined. Control flow patterns that cause recursion in the control flow analyzer (such as #11432) overflow the stack somewhere between 2500 and 5000 calls.
No RWC tests are affected by this change.
Fixes #14314 in the sense that it doesn't overflow the stack. However, #14314 still takes >80s to compile.