Narrow contextual type of object literals #18488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16457 (first half). This allows the following example to get the correct contextual type of
Y
for the object literal withtype: 'y'
.Note that many properties look like discriminants, but aren't particularly good ones. For example, the original example from #16457 has
X.value : string
andY.value: 'none' | 'some'
.string | 'none' | 'some'
is not a good discriminant and is not helped by this PR.