Fix bug: Report errors on extends
expression in JS even if an @augments
tag is present
#18854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #18775
Turns out
getBaseConstructorTypeOfClass
was the only place we checked theextends
expression, so that PR turned off checking if an@augments
tag was present.It would seem neater to have a
checkExpression(baseTypeNode)
call incheckClassLikeDeclaration
, but that would mean we check it twice in the usual case.