warn when generator function without any yield expression (#13847) #19413

Kingwl · 2017-10-23T07:13:44Z

mhegazy · 2017-10-30T21:23:45Z

src/compiler/checker.ts

@@ -18714,6 +18714,18 @@ namespace ts {
            }
        }

+        function checkGeneratorWithReturnStatementMustHaveYield (func: FunctionLikeDeclaration) {
+            let hasReturnStmt = false;
+            forEachReturnStatement(<Block>func.body, _ => hasReturnStmt = true);


seems weird that we have to do this walk again. we have already walked the yield statements to get the types a bit earlier. we can just report the error there instead.

mhegazy · 2017-10-30T21:52:10Z

src/compiler/diagnosticMessages.json

@@ -911,6 +911,10 @@
        "category": "Error",
        "code": 1329
    },
+    "generator with 'return statement' must not have zero 'yield return' statements.": {


A generator cannot have a return statement and no yield statements.

mhegazy · 2017-10-30T22:00:16Z

In light of the recent discussion about warnings vs. errors, i want to revisit our decision to accept this proposal in the first place.

…3847)

Kingwl force-pushed the generator-yield-and-return-check branch 2 times, most recently from 5a8a59c to a024434 Compare October 27, 2017 06:15

mhegazy suggested changes Oct 30, 2017

View reviewed changes

warn when generator function without any yield expression(microsoft#1…

e4576ed

…3847)

Kingwl force-pushed the generator-yield-and-return-check branch from a024434 to e4576ed Compare October 31, 2017 04:15

Kingwl closed this Oct 31, 2017

Kingwl deleted the generator-yield-and-return-check branch October 31, 2017 07:46

microsoft locked and limited conversation to collaborators Jun 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

warn when generator function without any yield expression (#13847) #19413

warn when generator function without any yield expression (#13847) #19413

Kingwl commented Oct 23, 2017

mhegazy Oct 30, 2017

mhegazy Oct 30, 2017

mhegazy commented Oct 30, 2017

warn when generator function without any yield expression (#13847) #19413

warn when generator function without any yield expression (#13847) #19413

Conversation

Kingwl commented Oct 23, 2017

mhegazy Oct 30, 2017

Choose a reason for hiding this comment

mhegazy Oct 30, 2017

Choose a reason for hiding this comment

mhegazy commented Oct 30, 2017